Call WalDataToDDLEvent once per event in the processor chain#970
Open
kvch wants to merge 3 commits into
Open
Conversation
9948ebe to
b902ac2
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every processor in the chain (filter, injector, transformer, and the postgres DDL adapter) independently called
WalDataToDDLEventon the same event, and each call ranjson.Unmarshal([]byte(d.Content)).From now on parsing result is cached. So there is no need for the expensive
json.Unmarshals.Cachingthe parse on
wal.Datareduces 5json.Unmarshalpasses per event down to 1 (+4 cached hits), cutting time and allocations ~74%. The gain scales with how many processors in the chain callWalDataToDDLEventon the same event.Type of Change
Please select the relevant option(s):
Testing
Checklist