Skip to content

chore: upgrade pnpm to v11 #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
comatory wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: upgrade pnpm to v11 #2872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
strict-peer-dependencies=false # If this is enabled, commands will fail if there is a missing or invalid peer dependency in the tree.
fetch-retries="10"
ignore-workspace-root-check=true
dedupe-peer-dependents=false
provenance=true
registry-url=https://registry.npmjs.org/
registry-url=https://registry.npmjs.org/
2 changes: 1 addition & 1 deletion admission-server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM --platform=${BUILDPLATFORM} node:lts AS builder
WORKDIR /app

# Ensure we have pnpm available to us
RUN npm install --global pnpm@9
RUN npm install --global pnpm@11.1.2

# Files required by pnpm install.
COPY .npmrc package.json pnpm-lock.yaml pnpm-workspace.yaml ./
Expand Down
2 changes: 1 addition & 1 deletion cdn-server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM --platform=${BUILDPLATFORM} node:lts AS builder
WORKDIR /app

# Ensure we have pnpm available to us
RUN npm install --global pnpm@9
RUN npm install --global pnpm@11.1.2

# Files required by pnpm install.
COPY .npmrc package.json pnpm-lock.yaml pnpm-workspace.yaml ./
Expand Down
4 changes: 2 additions & 2 deletions client-tests/apollo-js/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
FROM node:20-alpine

# Install pnpm
RUN corepack enable && corepack prepare pnpm@latest --activate
RUN corepack enable && corepack prepare pnpm@11.1.2 --activate
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

What is the minimum supported Node.js version for pnpm 11.x, and does pnpm 11.1.2 support Node 20?

💡 Result:

The minimum supported Node.js version for pnpm 11.x is Node.js 22 [1][2][3]. pnpm 11.x, including version 11.1.2, does not support Node.js 20 [1][2][3]. Support for Node.js 18, 19, 20, and 21 was dropped in the pnpm 11.0.0 release, as pnpm transitioned to being a pure ESM (ECMAScript Module) package [1][2]. Consequently, you must use Node.js 22 or newer to run pnpm 11.x [2][3].

Citations:

pnpm 11 is incompatible with Node 20; update the Dockerfile base image to Node 22.

The Dockerfile activates pnpm v11.1.2 on a Node 20-alpine base image, but pnpm 11.x requires Node.js 22 or newer (support for Node 18–21 was dropped in pnpm 11.0.0 due to the transition to pure ESM). Update the base image to Node 22 to ensure the test environment is compatible.

Proposed fix 
-FROM node:20-alpine
+FROM node:22-alpine
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@client-tests/apollo-js/Dockerfile` at line 5, The Dockerfile currently
activates pnpm@11.1.2 on a Node 20 base which is incompatible; update the
Dockerfile base image from Node 20 (e.g., node:20-alpine) to Node 22 (e.g.,
node:22-alpine) so the existing RUN corepack enable && corepack prepare
pnpm@11.1.2 --activate works correctly; keep the RUN line as-is but ensure the
FROM line references Node 22 so pnpm 11 is supported.


# Set working directory
WORKDIR /app
Expand All @@ -17,4 +17,4 @@ RUN pnpm install
COPY . .

# Run tests
CMD ["pnpm", "test"]
CMD ["pnpm", "test"]
2 changes: 1 addition & 1 deletion client-tests/apollo-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"keywords": [],
"author": "",
"license": "ISC",
"packageManager": "pnpm@9.12.3",
"packageManager": "pnpm@11.1.2",
"devDependencies": {
"@apollo/client": "^3.13.9",
"@types/node": "^22.17.0",
Expand Down
Loading
Loading