Skip to content

feat(router): allow fallback cdn url to be specified #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pepol wants to merge 3 commits into
base: main
Choose a base branch
from

chore: review number 2

55c2efe
Select commit
Loading
Failed to load commit list.
Draft

feat(router): allow fallback cdn url to be specified #2807

chore: review number 2
55c2efe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 15, 2026 in 0s

59.61% (target 30.00%)

View this Pull Request on Codecov

59.61% (target 30.00%)

Details

Codecov Report

❌ Patch coverage is 26.57005% with 152 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.61%. Comparing base (a6a6956) to head (55c2efe).
⚠️ Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
router/pkg/routerconfig/cdn/client.go 11.66% 49 Missing and 4 partials ⚠️
...internal/persistedoperation/pqlmanifest/fetcher.go 27.27% 27 Missing and 5 partials ⚠️
.../persistedoperation/operationstorage/cdn/client.go 35.00% 23 Missing and 3 partials ⚠️
router/core/cache_warmup_cdn.go 41.86% 22 Missing and 3 partials ⚠️
router/internal/httpclient/fallback.go 0.00% 12 Missing ⚠️
router/core/init_config_poller.go 0.00% 2 Missing ⚠️
router/core/router.go 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2807       +/-   ##
===========================================
+ Coverage   41.70%   59.61%   +17.90%     
===========================================
  Files         791      239      -552     
  Lines      113325    26001    -87324     
  Branches     8768        0     -8768     
===========================================
- Hits        47266    15501    -31765     
+ Misses      65695     9003    -56692     
- Partials      364     1497     +1133
Files with missing lines Coverage Δ
router/core/graph_server.go 83.12% <100.00%> (ø)
router/pkg/config/config.go 50.64% <ø> (ø)
router/core/init_config_poller.go 3.03% <0.00%> (ø)
router/core/router.go 69.20% <60.00%> (ø)
router/internal/httpclient/fallback.go 0.00% <0.00%> (ø)
router/core/cache_warmup_cdn.go 54.08% <41.86%> (ø)
.../persistedoperation/operationstorage/cdn/client.go 56.91% <35.00%> (ø)
...internal/persistedoperation/pqlmanifest/fetcher.go 44.08% <27.27%> (ø)
router/pkg/routerconfig/cdn/client.go 34.32% <11.66%> (ø)

... and 1021 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov