Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2958f1d
feat(router): entity caching with L1/L2, shadow mode, and analytics
jensneuse Apr 20, 2026
4bf4040
fix(entity-caching): address PR #2777 review items across composition…
jensneuse Apr 23, 2026
49fb668
Merge remote-tracking branch 'origin/main' into jensneuse/entity-cach…
jensneuse Apr 23, 2026
9dd235a
fix(entity-caching): CI follow-ups — prettier + gqlgen-safe var place…
jensneuse Apr 23, 2026
61f64a1
fix(entity-caching): second round of PR #2777 review items
jensneuse Apr 23, 2026
de8a611
fix(composition): run prettier on AGENTS.md
jensneuse Apr 23, 2026
78d9c32
docs: add entity caching pre-release test kit
jensneuse Apr 24, 2026
699c310
fix(composition): third round of PR #2777 review items (#9, #10, #11,…
jensneuse Apr 24, 2026
23d748c
docs: make entity caching pre-release kit self-contained
jensneuse Apr 24, 2026
294b2d9
fix(router): opt-in for entity cache telemetry (PR #2777 review #21)
jensneuse Apr 24, 2026
03cc34f
docs: use Yoga for pre-release test subgraph
jensneuse Apr 24, 2026
9664044
fix(router-tests): entity cache test cleanup (PR #2777 review #3, #4,…
jensneuse Apr 24, 2026
986bca7
docs: load pre-release test schema from SDL
jensneuse Apr 24, 2026
3dc656e
fix(demo): demo hardening (PR #2777 review #13, #14, #15)
jensneuse Apr 24, 2026
3dfab5d
fix(benchmark,docs): rename mode + document TTL divergence (PR #2777 …
jensneuse Apr 24, 2026
bc4787a
docs(entity-caching): clarify Coordinate L1 vs Entity L1 (PR #2777 re…
jensneuse Apr 24, 2026
898d8f9
docs: harden entity caching smoke test
jensneuse Apr 24, 2026
e966bf8
docs: document entity caching PR checkout
jensneuse Apr 24, 2026
87fe366
docs: explain pre-release cache configuration
jensneuse Apr 24, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,11 @@ go.work.sum

# Serena
.serena/
/.playwright-mcp

# PR review workspace — local-only, never commit
/TODO.md
/DONE.md
/FEEDBACK.md
/COMMENTS.md
/docs/superpowers/
302 changes: 301 additions & 1 deletion CLAUDE.md

Large diffs are not rendered by default.

42 changes: 42 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,48 @@ docker-build-minikube: docker-build-local

rm -f mk-*.tar

demo-compose:
cd demo && $(MAKE) compose-cache

demo:
@echo "Composing subgraph schemas..."
cd demo && $(MAKE) compose-cache
@echo "Starting subgraphs and router..."
@echo "Playground will be at http://localhost:3002/"
@set -e; \
cd demo && go run cmd/all/main.go & \
pid=$$!; \
trap 'kill $$pid 2>/dev/null || true' EXIT INT TERM HUP; \
for p in 4012 4013 4014; do \
for i in 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20; do \
nc -z 127.0.0.1 $$p && break; \
sleep 0.5; \
done; \
nc -z 127.0.0.1 $$p || { echo "subgraph $$p did not start" >&2; exit 1; }; \
done; \
Comment thread
coderabbitai[bot] marked this conversation as resolved.
cd router && go run cmd/router/main.go --config ../demo/router-cache.yaml

benchmark-cache-demo:
pnpm dlx tsx benchmark/scripts/run_suite.ts --all \
$(if $(VUS),--vus $(VUS),) \
$(if $(DURATION),--duration $(DURATION),) \
$(if $(RAMP_UP),--ramp-up $(RAMP_UP),) \
$(if $(RAMP_DOWN),--ramp-down $(RAMP_DOWN),)

benchmark-cache-demo-scenario:
@if [ -z "$(SCENARIO)" ]; then \
echo "Usage: make benchmark-cache-demo-scenario SCENARIO=<scenario_name>"; \
exit 1; \
fi
pnpm dlx tsx benchmark/scripts/run_suite.ts --scenario $(SCENARIO) \
$(if $(VUS),--vus $(VUS),) \
$(if $(DURATION),--duration $(DURATION),) \
$(if $(RAMP_UP),--ramp-up $(RAMP_UP),) \
$(if $(RAMP_DOWN),--ramp-down $(RAMP_DOWN),)

benchmark-cache-demo-validate:
pnpm dlx tsx benchmark/scripts/run_suite.ts validate

run-subgraphs-local:
cd demo && go run cmd/all/main.go

Expand Down
5 changes: 5 additions & 0 deletions benchmark/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.run/
.tmp-metrics/
.tmp-pprof/
results/*
!results/.gitkeep
114 changes: 114 additions & 0 deletions benchmark/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
# Cache Demo Benchmark Suite

Local benchmark harness for the cache demo on `localhost:3002`, using:

- the existing `cache-demo` subgraphs
- a dedicated Redis Docker container for L2 cache storage on `localhost:6399`
- k6 for request load
- router Prometheus and pprof for runtime capture

## Prerequisites

- `go` with the repo’s expected toolchain
- `pnpm`
- `k6`
- `docker`
- free local ports:
- `3002`
- `4012`
- `4013`
- `4014`
- `6060`
- `8088`
- `6399`

## Key Files

- `benchmark/router-cache.redis.yaml`: Redis-backed router config for the benchmark
- `benchmark/scenarios/cache-demo.json`: scenario manifest
- `benchmark/queries/*.graphql`: canonical benchmark operations
- `benchmark/fixtures/*.response.json`: uncached router response fixtures
- `benchmark/k6/cache_demo.js`: k6 runner with exact response assertion

## Scenarios

- `article_simple`
- `articles_by_ids_batch`
- `listing_composite_key`
- `venue_nested_key`
- `user_profile_header_sensitive`
- `catalogs_partial_load`
- `request_scoped_viewer_articles`
- `viewer_articles_deep_nested`

## Auth Profiles

The demo uses fake bearer tokens:

- `alice` -> `Bearer token-alice`
- `bob` -> `Bearer token-bob`
- `charlie` -> `Bearer token-charlie`

Auth-sensitive scenarios must not fall back to anonymous requests.

## Commands

Validate the manifest and checked-in fixtures:

```bash
make benchmark-cache-demo-validate
```

Run the full suite with default load settings:

```bash
make benchmark-cache-demo
```

Run one scenario with default load settings:

```bash
make benchmark-cache-demo-scenario SCENARIO=article_simple
```

Run one scenario with direct control over k6 stages:

```bash
pnpm dlx tsx benchmark/scripts/run_suite.ts \
--scenario article_simple \
--vus 10 \
--duration 30s \
--ramp-up 5s \
--ramp-down 5s
```

## Output Layout

Result bundles are written under:

```text
benchmark/results/<timestamp>/<scenario>/<mode>/
```

Each mode directory contains:

- `summary.json`
- `k6-summary.json`
- `metrics-before.prom`
- `metrics-after.prom`
- `metrics-delta.json`
- `redis-info-before.txt`
- `redis-info-after.txt`
- `redis-docker-stats-before.json`
- `redis-docker-stats-after.json`
- `equivalence.json`
- `pprof/router_cpu.pb.gz`
- `pprof/router_heap.pb.gz`

`summary.json` also records the warmup request count, k6 stage config, parsed k6 summary, and selected Redis INFO and Docker stats values so downstream interpretation does not need to scrape raw artifacts first.

## Notes

- The harness owns the stack. If the required ports are already in use, startup fails rather than benchmarking against a dirty environment.
- L2 cache storage is intentionally externalized to Redis so router memory measurements do not include the full L2 object footprint.
- The suite always performs deterministic uncached equivalence checks before load generation and serial warmup requests before each mode run.
1 change: 1 addition & 0 deletions benchmark/fixtures/article_simple.response.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"data":{"article":{"id":"1","title":"Introduction to GraphQL Caching","authorName":"Alice"}}}
1 change: 1 addition & 0 deletions benchmark/fixtures/articles_by_ids_batch.response.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"data":{"articlesByIds":[{"id":"1","title":"Introduction to GraphQL Caching","authorName":"Alice"},{"id":"2","title":"Advanced Federation Patterns","authorName":"Bob"},{"id":"3","title":"Cache Invalidation Strategies","authorName":"Charlie"}]}}
1 change: 1 addition & 0 deletions benchmark/fixtures/catalogs_partial_load.response.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"data":{"catalogs":[{"id":"c1","name":"Electronics","description":"Consumer electronics, gadgets, and accessories.","lastUpdated":"2025-03-15T08:00:00Z","itemCount":342},{"id":"c2","name":"Books","description":"Fiction, non-fiction, technical books, and audiobooks.","lastUpdated":"2025-03-20T12:00:00Z","itemCount":1205},{"id":"c3","name":"Clothing","description":"Men's, women's, and children's apparel.","lastUpdated":"2025-03-25T16:00:00Z","itemCount":567}]}}
1 change: 1 addition & 0 deletions benchmark/fixtures/listing_composite_key.response.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"data":{"listing":{"sellerId":"s1","sku":"WIDGET-01","title":"Premium Widget","price":29.99,"currency":"USD","inStock":true}}}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"data":{"currentViewer":{"id":"v1","name":"Alice","email":"alice@example.com"},"articles":[{"id":"1","title":"Introduction to GraphQL Caching","currentViewer":{"id":"v1","name":"Alice"},"viewCount":12453,"rating":4.7},{"id":"2","title":"Advanced Federation Patterns","currentViewer":{"id":"v1","name":"Alice"},"viewCount":8921,"rating":4.3},{"id":"3","title":"Cache Invalidation Strategies","currentViewer":{"id":"v1","name":"Alice"},"viewCount":15678,"rating":4.9},{"id":"4","title":"Performance Tuning with Entity Caching","currentViewer":{"id":"v1","name":"Alice"},"viewCount":6234,"rating":4.1}]}}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"data":{"userProfile":{"id":"u1","username":"alice","role":"admin","email":"alice@example.com"}}}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"data":{"userProfile":{"id":"u2","username":"bob","role":"editor","email":"bob@example.com"}}}
1 change: 1 addition & 0 deletions benchmark/fixtures/venue_nested_key.response.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"data":{"venue":{"address":{"id":"v1"},"name":"Grand Conference Hall","capacity":500,"city":"Berlin"}}}

Large diffs are not rendered by default.

123 changes: 123 additions & 0 deletions benchmark/k6/cache_demo.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
import http from "k6/http";
import { check, fail } from "k6";
import { Counter, Rate } from "k6/metrics";

const payload = JSON.parse(__ENV.BENCHMARK_PAYLOAD || "{}");

if (!payload.url || !payload.query) {
fail("BENCHMARK_PAYLOAD must include url and query");
}

const mismatchRate = new Rate("response_mismatch_rate");
const graphqlErrorRate = new Rate("graphql_error_rate");
const mismatchCount = new Counter("response_mismatch_count");

function normalizeJson(value) {
if (Array.isArray(value)) {
return value.map((item) => normalizeJson(item));
}

if (value !== null && typeof value === "object") {
const out = {};
for (const key of Object.keys(value).sort()) {
out[key] = normalizeJson(value[key]);
}
return out;
}

return value;
}

function normalizeResponseForComparison(value) {
if (value === null || typeof value !== "object" || Array.isArray(value)) {
return normalizeJson(value);
}

const response = JSON.parse(JSON.stringify(value));
const extensions = response.extensions;

if (extensions && typeof extensions === "object" && !Array.isArray(extensions)) {
delete extensions.trace;

if (Object.keys(extensions).length === 0) {
delete response.extensions;
}
}

return normalizeJson(response);
}

const expectedBody = JSON.stringify(
normalizeResponseForComparison(payload.expectedBody),
);

export const options = payload.options || {
stages: [
{ duration: "30s", target: 20 },
{ duration: "2m", target: 20 },
{ duration: "10s", target: 0 },
],
};

export default function () {
const mergedHeaders = Object.assign(
{ "content-type": "application/json" },
payload.headers || {},
);

const response = http.post(
payload.url,
JSON.stringify({
operationName: payload.operationName,
query: payload.query,
variables: payload.variables || {},
}),
{
headers: mergedHeaders,
},
);

const ok = check(response, {
"http status is 200": (res) => res.status === 200,
});

if (!ok) {
mismatchRate.add(true);
mismatchCount.add(1);
graphqlErrorRate.add(false);
return;
}

let body;
try {
body = response.json();
} catch (_err) {
// Parse failure is both a response mismatch and a graphql-error-equivalent
// (the server returned a non-JSON body or truncated JSON under load).
mismatchRate.add(true);
mismatchCount.add(1);
graphqlErrorRate.add(true);
return;
}

const hasGraphqlErrors = Array.isArray(body?.errors) && body.errors.length > 0;
graphqlErrorRate.add(hasGraphqlErrors);

const sameBody =
JSON.stringify(normalizeResponseForComparison(body)) === expectedBody;

const assertionOk = check(
{ body, sameBody, hasGraphqlErrors },
{
"graphql errors absent": (data) => !data.hasGraphqlErrors,
"response matches expected fixture": (data) => data.sameBody,
},
);

if (!assertionOk || !sameBody) {
mismatchRate.add(true);
mismatchCount.add(1);
} else {
mismatchRate.add(false);
}
}
7 changes: 7 additions & 0 deletions benchmark/queries/article_simple.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
query ArticleSimple($id: ID!) {
article(id: $id) {
id
title
authorName
}
}
7 changes: 7 additions & 0 deletions benchmark/queries/articles_by_ids_batch.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
query ArticlesByIdsBatch($ids: [ID!]!) {
articlesByIds(ids: $ids) {
id
title
authorName
}
}
9 changes: 9 additions & 0 deletions benchmark/queries/catalogs_partial_load.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
query CatalogsPartialLoad {
catalogs {
id
name
description
lastUpdated
itemCount
}
}
10 changes: 10 additions & 0 deletions benchmark/queries/listing_composite_key.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
query ListingCompositeKey($key: ListingKey!) {
listing(key: $key) {
sellerId
sku
title
price
currency
inStock
}
}
17 changes: 17 additions & 0 deletions benchmark/queries/request_scoped_viewer_articles.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
query RequestScopedViewerArticles {
currentViewer {
id
name
email
}
articles {
id
title
currentViewer {
id
name
}
viewCount
rating
}
}
8 changes: 8 additions & 0 deletions benchmark/queries/user_profile_header_sensitive.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
query UserProfileHeaderSensitive($id: ID!) {
userProfile(id: $id) {
id
username
role
email
}
}
10 changes: 10 additions & 0 deletions benchmark/queries/venue_nested_key.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
query VenueNestedKey($location: VenueLocationKey!) {
venue(location: $location) {
address {
id
}
name
capacity
city
}
}
Loading
Loading