fix(update): refuse to update Homebrew-managed binary#6
Merged
pszymkowiak merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
Detects /Cellar/ or /homebrew/ in current_exe() path and aborts with a message directing user to 'brew upgrade wshm'. Prevents breaking the Cellar structure and Homebrew metadata. Also warns for /usr/bin/ paths which may be managed by apt/dnf/rpm. Same pattern as rtk-ai/icm#105.
Collaborator
Author
📊 Automated PR Analysis
SummaryAdds detection for Homebrew-managed and system package-managed installations in the self-update flow. Refuses to overwrite Homebrew binaries (bailing with a helpful message) and warns when the binary resides in /usr/bin/, suggesting the user upgrade via their package manager instead. Review Checklist
Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents
wshm update --applyfrom breaking Homebrew/apt metadata. Detects/Cellar/or/homebrew/in the current exe path and tells user to usebrew upgrade wshminstead.Same pattern as rtk-ai/icm#105.