Skip to content

Include mp_physics=88 in TEMPO error print message#2325

Merged
weiwangncar merged 1 commit into
wrf-model:release-v4.8.0from
kkeene44:my_releasev480
May 21, 2026
Merged

Include mp_physics=88 in TEMPO error print message#2325
weiwangncar merged 1 commit into
wrf-model:release-v4.8.0from
kkeene44:my_releasev480

Conversation

@kkeene44
Copy link
Copy Markdown
Collaborator

@kkeene44 kkeene44 commented May 7, 2026

TYPE: text only

KEYWORDS: TEMPO, mp_physics=88, module_initialize_real, print, error

SOURCE: Internal

DESCRIPTION OF CHANGES:
Problem:
Previously-added code to module_initialize_real checked to ensure if using TEMPO microphysics (option 88) with tempo_hailware=1 and tempo_aerosolaware=1, without setting wif_input_opt=1, the model stopped with a fatal error. However, the error message only implied the user set mp_physics to 28 or 29.

Solution:
Included mp_physics=88 in the error message

LIST OF MODIFIED FILES:
M dyn_em/module_initialize_real.F

TESTS CONDUCTED:

  1. Mods fix the problem. Running real.exe now gives an error message that includes an mp_physics=88 (TEMPO) setting.
  2. The Jenkins tests are all passing with text only change.

@weiwangncar
Copy link
Copy Markdown
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Copy Markdown
Collaborator

@AndersJensen-NOAA Can you help review this PR? Thanks.

Comment thread dyn_em/module_initialize_real.F
@weiwangncar
Copy link
Copy Markdown
Collaborator

@kkeene44 Please see suggestion by Anders.

@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented May 20, 2026

@weiwangncar this can be reviewed and approved.

@weiwangncar weiwangncar merged commit 02f02bc into wrf-model:release-v4.8.0 May 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants