Conversation
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy@hergault.fr>
oschijns
reviewed
May 31, 2026
Comment on lines
+104
to
+114
| /// use prosa::core::main::{MainProc, MainRunnable}; | ||
| /// use prosa::core::proc::{proc, Proc, ProcBusParam, ProcConfig}; | ||
| /// use prosa::inj::adaptor::InjDummyAdaptor; | ||
| /// use prosa::inj::proc::{InjProc, InjSettings}; | ||
| /// use prosa_utils::config::observability::Observability; | ||
| /// use prosa::{ | ||
| /// core::{ | ||
| /// main::{MainProc, MainRunnable}, | ||
| /// proc::{proc, Proc, ProcBusParam, ProcConfig}, | ||
| /// settings::{settings, observability::Observability}, | ||
| /// }, | ||
| /// inj::{ | ||
| /// adaptor::InjDummyAdaptor, | ||
| /// proc::{InjProc, InjSettings}, | ||
| /// }, | ||
| /// }; |
Contributor
There was a problem hiding this comment.
Maybe we could use the mod::* pattern in documentation to reduce the amount of imports necessary and focus the documentation on the actual example.
/// use prosa::{core::{main::*, proc::*, settings::*}, inj::{adaptor::*, proc::*}};
/// use prosa_utils::msg::simple_string_tvf::SimpleStringTvf;
/// use serde::Serialize;
Contributor
Author
There was a problem hiding this comment.
Yes let's do this. Let's consider no other symbols will have the same name.
Comment on lines
+42
to
+52
| /// use prosa::core::main::{MainProc, MainRunnable}; | ||
| /// use prosa::core::proc::{proc, Proc, ProcBusParam, ProcConfig}; | ||
| /// use prosa::stub::adaptor::StubParotAdaptor; | ||
| /// use prosa::stub::proc::{StubProc, StubSettings}; | ||
| /// use prosa_utils::config::observability::Observability; | ||
| /// use prosa::{ | ||
| /// core::{ | ||
| /// main::{MainProc, MainRunnable}, | ||
| /// proc::{proc, Proc, ProcBusParam, ProcConfig}, | ||
| /// settings::{settings, observability::Observability}, | ||
| /// }, | ||
| /// stub::{ | ||
| /// adaptor::StubParotAdaptor, | ||
| /// proc::{StubProc, StubSettings}, | ||
| /// }, | ||
| /// }; |
Contributor
There was a problem hiding this comment.
Same here, imports could be simplified further.
/// use prosa::{core::{main::*, proc::*, settings::*}, stub::{adaptor::*, proc::*}};
/// use prosa_utils::msg::simple_string_tvf::SimpleStringTvf;
/// use serde::Serialize;
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
oschijns
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.