[QA] add: BCDC e2e tests for classic checkout (Mexico)#4297
Open
syde-piotr-ostrowski wants to merge 6 commits intodev/developfrom
Open
[QA] add: BCDC e2e tests for classic checkout (Mexico)#4297syde-piotr-ostrowski wants to merge 6 commits intodev/developfrom
syde-piotr-ostrowski wants to merge 6 commits intodev/developfrom
Conversation
syde-piotr-ostrowski
requested review from
AlexP11223,
Dinamiko,
Narek13,
danieldudzic,
hmouhtar,
mmaymo and
stracker-phil
as code owners
mishautkin
requested changes
Apr 28, 2026
Collaborator
Author
|
@mishautkin Updated the BCDC naming and billing form handling as suggested |
mishautkin
requested changes
Apr 29, 2026
Collaborator
mishautkin
left a comment
mishautkin
left a comment
There was a problem hiding this comment.
Looks much better but please cleanup the remaining standardCardButton and debitOrCreditCard in favor of bcdc. Thank you!
| // Latin America (Mexico) uses minimal mode: PayPal shows its own billing form inside the modal | ||
| // Fill those fields from the WC checkout form when they are visible. | ||
| // Latin America (Mexico) uses minimal mode: PayPal shows its own billing form inside the modal. | ||
| const firstNameInput = this.standardCardButtonFirstNameInput(); |
Collaborator
There was a problem hiding this comment.
Since we decided to get rid from standardCardButton and debitOrCreditCard in favor of bcdc, could you please also rename the locator methods (prefixed standardCardButton/debitOrCreditCard) with and cleanup unused ones?
| @@ -357,7 +359,8 @@ export class PayPalUi { | |||
| // Standard Card Button | |||
| if ( gateway.id === 'ppcp-card-button-gateway' ) { | |||
| await this.completeStandardCardButtonPayment( | |||
Collaborator
There was a problem hiding this comment.
rename to completeBcdcPayment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves PCP-5985
Covers:
These tests were present in the legacy UI tests set, but were not present in the tests covering new UI.
These scenarios are still applicable to the current plugin codebase and now they are will be available again.
One of the tests (PCP-1211) was tagged
Critical.The tests run against a Mexico merchant. A helper was added to handle PayPal's billing address form that appears inside the card modal for Latin America.