Refactor scroll-and-highlight to use React context instead of direct DOM manipulation (4272)#4255
Open
danieldudzic wants to merge 105 commits intodev/developfrom
Conversation
…les-from-build ACDC eligible merchant onboarded as BCDC on fresh install (6055)
…ly-crypto Improve Pay with Crypto visibility and messaging across the plugin settings and checkout (6059)
…pansion-card-fields Derive card-fields country matrix from DCC matrix (5840)
Exclude development-only files in .distignore
The issue itself was fixed in commit 2e5547a
…ui-and-oxxo-do-not-persist-after-upgrade-from-2-9-6-to-4-0-0 Migration - PUI and OXXO do not persist after upgrade from 2.9.6 to 4.0.0 (6046 v2)
…er-remove-text-us-only-related-to-fastlane Migration banner — remove Fastlane US-only text (6056)
…e_for_virtual_only Migrate "capture for virtual only" (6026)
…h-site-after-payment-with-pui-orders-stuck-on-status-on-hold-as-webhook-are-not-registered On fresh site after payment with PUI orders stuck on status on hold as webhook are not registered (6062)
…6 → v4.0.0 settings migration
…-errors Harden plugin init to prevent errors during update (6063)
…pal-title-and-description-not-saved-after-migration Migration - PayPal title and description not saved after migration (6068)
…-references Remove UI flag references (6067)
…or-new-merchant Do not migrate New-UI-Only merchants (6096)
…0.0-take-2 Bump release date to today
Bump version to 4.0.1 for release
API rate limiting fix (6101)
…ocations-disabled-after-updating-to-4-0-0 Fix smart button locations being disabled after updating (6096)
…nresolvable unknown seller type
Fix missing Online Card Payments section after upgrade from 2.9.x
Update release dates for 4.0.2 in changelog.txt and readme.txt
…ct DOM manipulation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is dependent on changes from https://github.com/woocommerce/woocommerce-paypal-payments/tree/dev/release/4.0.2
Description
Refactors the scroll-and-highlight system from direct DOM manipulation (
classList.add/remove,document.getElementById) to a React context-based approach usingScrollHighlightProvider,useScrollTarget, anduseScrollTohooks.Steps to Test
?highlight=ppcp-save-paypal-and-venmoURL parameter — verify it scrolls to "Save PayPal and Venmo" and highlights it