Update calendar display option text to clarify user interaction#589
Draft
faisal-alvi wants to merge 2 commits intotrunkfrom
Draft
Update calendar display option text to clarify user interaction#589faisal-alvi wants to merge 2 commits intotrunkfrom
faisal-alvi wants to merge 2 commits intotrunkfrom
Conversation
|
This is linked to GitHub issue #590. |
iamdharmesh
approved these changes
Mar 23, 2026
Collaborator
iamdharmesh
left a comment
There was a problem hiding this comment.
Thanks for PR @faisal-alvi. Looks good to me.
However, we want to hold merging this until the upstream changes get merged.
Collaborator
Author
|
Noting specifically that this one depends on https://github.com/woocommerce/woocommerce-bookings/pull/4220 being merged first. |
Collaborator
qasumitbagthariya
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

All Submissions:
Changes proposed in this Pull Request:
Renamed dropdown option: "Display calendar on click" → "Display calendar on click or focus"
Follow-up changes after https://github.com/woocommerce/woocommerce-bookings/pull/4224
Closes https://linear.app/a8c/issue/WOOA11Y-318/a11y-calendar-not-accessible-to-keyboard-and-screen-reader-users.
Steps to test the changes in this Pull Request:
Just add/edit any accommodation product and verify the dropdown text looks as shown in the following screenshot.
Changelog entry
Closes #590