Skip to content

Update calendar display option text to clarify user interaction#589

Draft
faisal-alvi wants to merge 2 commits intotrunkfrom
WOOA11Y-318
Draft

Update calendar display option text to clarify user interaction#589
faisal-alvi wants to merge 2 commits intotrunkfrom
WOOA11Y-318

Conversation

@faisal-alvi
Copy link
Copy Markdown
Collaborator

@faisal-alvi faisal-alvi commented Mar 12, 2026

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

Renamed dropdown option: "Display calendar on click" → "Display calendar on click or focus"

Follow-up changes after https://github.com/woocommerce/woocommerce-bookings/pull/4224

Closes https://linear.app/a8c/issue/WOOA11Y-318/a11y-calendar-not-accessible-to-keyboard-and-screen-reader-users.

Steps to test the changes in this Pull Request:

Just add/edit any accommodation product and verify the dropdown text looks as shown in the following screenshot.

image

Changelog entry

Change - Update calendar display option text to clarify user interaction

Closes #590

@faisal-alvi faisal-alvi requested a review from iamdharmesh March 12, 2026 10:50
@faisal-alvi faisal-alvi self-assigned this Mar 12, 2026
@github-actions
Copy link
Copy Markdown

This is linked to GitHub issue #590.

Copy link
Copy Markdown
Collaborator

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @faisal-alvi. Looks good to me.

However, we want to hold merging this until the upstream changes get merged.

@faisal-alvi faisal-alvi requested review from qasumitbagthariya and removed request for qasumitbagthariya April 7, 2026 10:38
@faisal-alvi
Copy link
Copy Markdown
Collaborator Author

Noting specifically that this one depends on https://github.com/woocommerce/woocommerce-bookings/pull/4220 being merged first.

@qasumitbagthariya
Copy link
Copy Markdown
Collaborator

QA update:

Verified that the dropdown option has been updated from ‘Display calendar on click’ to ‘Display calendar on click or focus’ as expected.

image

Testing Environment

Details
  • WordPress: 6.9.4
  • Theme: Twenty Twenty-Five 1.4
  • WooCommerce - 10.6.2
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: WOOA11Y-318

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue for PR #589: Update calendar display option text to clarify user interaction

3 participants