Skip to content

create secure context to use cert client auth and validate server ca#231

Open
ymahlaoui wants to merge 1 commit into
winstonjs:masterfrom
ymahlaoui:master
Open

create secure context to use cert client auth and validate server ca#231
ymahlaoui wants to merge 1 commit into
winstonjs:masterfrom
ymahlaoui:master

Conversation

@ymahlaoui
Copy link
Copy Markdown

This mod is for using cert client auth to syslog server and also validate the server cet

@DABH
Copy link
Copy Markdown
Contributor

DABH commented Jan 4, 2024

I think this would break things for users using secureProtocol, which doesn't seem ideal. Do you have any thoughts on that? Should we support both secureProtocol and secureContext fields? In any case, if we wanted to accept this PR, it would be very helpful to add a test and ideally some documentation, too, so people know what this is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants