Add for='' values to the subvalues of several concepts. Closes #12457#12458
Open
tabatkins wants to merge 2 commits into
Open
Add for='' values to the subvalues of several concepts. Closes #12457#12458tabatkins wants to merge 2 commits into
tabatkins wants to merge 2 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
annevk
reviewed
May 15, 2026
annevk
reviewed
May 16, 2026
|
|
||
| <p>Each <span>media element</span> has a unique <dfn>media element event task source</dfn>.</p> | ||
| <p>Each <span>media element</span> has a unique <dfn for="media element">media element event task | ||
| source</dfn>.</p> |
Member
There was a problem hiding this comment.
I'm still somewhat surprised this is needed or desired. Who else is defining a media element event task source? Shouldn't they reference this one?
Contributor
Author
There was a problem hiding this comment.
I mean, I added the attribute because I mistook it for being part of the preceding "media resource" block of sub-dfns, but this is still a sub-dfn and it's not wrong to give it a for value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an editorial-only edit. It adds
for="'attributes to the sub-dfns of four concepts, all of which happen to include "origin" as one of their sub-dfns. (They're mostly structs.)This closes #12457, where the multiple un-for'd "origin" definitions cause Bikeshed trouble. Tho only the "origin" terms were problematic here, I added the
for=""to all the sub-dfns for consistency, and to avoid future similar issues.Beyond adding the attribute to several
dfnelements, the only other changes are necessary rewrapping of the paragraphs./browsers.html ( diff )
/browsing-the-web.html ( diff )
/media.html ( diff )
/speculative-loading.html ( diff )