Remove fragment parsing special case for input tags#12420
Closed
josepharhar wants to merge 1 commit into
Closed
Conversation
A special case was added for fragment parsing `<select>` when assigning innerHTML of another select element due to a regression bug, which I documented here: whatwg#10310 (comment) However, this special case was copied over to input tags as well, which was recently noticed here but was never implemented in chromium or html5lib-tests: html5lib/html5lib-tests#195 This PR removes this special case to match implementations and tests. Allowing input tags inside select is also something that I'm looking into supporting separately, and this case has been supported in stable chromium for long enough that I don't think it is breaking any websites.
Contributor
Author
|
After doing more digging, I found the reason why this was added: #10557 (comment) I just never implmented it. I guess that if we change how input tags are parsed inside select, we could just make the innerHTML case match the regular parsing case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A special case was added for fragment parsing
<select>when assigning innerHTML of another select element due to a regression bug, which I documented here: #10310 (comment)However, this special case was copied over to input tags as well, which was recently noticed here but was never implemented in chromium or html5lib-tests: html5lib/html5lib-tests#195
This PR removes this special case to match implementations and tests. Allowing input tags inside select is also something that I'm looking into supporting separately, and this case has been supported in stable chromium for long enough that I don't think it is breaking any websites.
(See WHATWG Working Mode: Changes for more details.)
/parsing.html ( diff )