Add soulreaper stacks to ttk dist#769
Open
jmyaeger wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the soulreaper axe's passive effect to the TTK distribution plot. It starts at whatever number of stacks the user sets in the loadout options, and it adds stacks for each attack until reaching the cap of 5. It also works with HP-dependent cases (Vardorvis).
I tested this against simulations that I'm fairly confident are correct, and I got matching average TTKs for both an HP-invariant case and for Vardorvis when starting at 0 stacks and resetting stacks to 0 at the beginning of each kill.
I'd like to try to add soulreaper stacks to
getHtk()(and by extensiongetTtk()) to eliminate the mismatch between the table and plot, but I figured I would separate out the PRs (also, I'd ideally like it to be added onto thegetHtk()version in #755 that considers HP-dependent hit dists, if that PR gets accepted).