feat(vscode): add workspaceRoot config option to enable use in a VSCode workspace that does not have package.json at the workspace root#1667
Open
anmilleriii wants to merge 2 commits into
Conversation
workspaceRoot config for VSCode open in non-root workspaceworkspaceRoot config option to customize workspace root
workspaceRoot config option to customize workspace rootworkspaceRoot config option to enable opening a VSCode workspace that does not have package.json at the workspace root
workspaceRoot config option to enable opening a VSCode workspace that does not have package.json at the workspace rootworkspaceRoot config option to enable use in a VSCode workspace that does not have package.json at the workspace root
2842c6f to
1803f9f
Compare
67650e2 to
c226a72
Compare
Member
|
Thanks for PR! Agreed this is good to have. Took the time to dive into the VS Code extension, and this is a slightly more minimal version. Can you please confirm this works for you as well? |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When opening a VSCode workspace of the following structure with the extension, where the workspace root does not contain a package manifest file
Knip will fail with
Solution
This adds a
workspaceRootoption to the VSCode settings config to specify a knip root other than the currently open VSCode workspace.This config:
Yields