[breaking] Add message argument to QueueWorkDoneCallback#528
Merged
kainino0x merged 2 commits intowebgpu-native:mainfrom May 1, 2025
Merged
[breaking] Add message argument to QueueWorkDoneCallback#528kainino0x merged 2 commits intowebgpu-native:mainfrom
kainino0x merged 2 commits intowebgpu-native:mainfrom
Conversation
kainino0x
added
the
post-RC breaking change
lokokung
approved these changes
Apr 25, 2025
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
May 30, 2025
Following upstream webgpu.h change: webgpu-native/webgpu-headers#528 Bug: 414868699 Change-Id: Ieaf72cd4a295d60659d0cdc20f1e0f95ff054684 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/243697 Reviewed-by: Loko Kung <lokokung@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
May 30, 2025
…ack" This reverts commit f6d857e. Reason for revert: blocking Dawn -> chromium roll Bug: 414868699 Original change's description: > [dawn][emscripten] Add message argument to QueueWorkDoneCallback > > Following upstream webgpu.h change: > webgpu-native/webgpu-headers#528 > > Bug: 414868699 > Change-Id: Ieaf72cd4a295d60659d0cdc20f1e0f95ff054684 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/243697 > Reviewed-by: Loko Kung <lokokung@google.com> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> TBR=kainino@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 414868699 Change-Id: I88c130ea80884d9e2eada2ce274b276d13f52553 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/244594 Reviewed-by: Shrek Shao <shrekshao@google.com> Reviewed-by: James Price <jrprice@google.com> Reviewed-by: Loko Kung <lokokung@google.com> Commit-Queue: James Price <jrprice@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
Jun 3, 2025
…ack" This reverts commit 3df36f7. Reason for revert: Breaking change handled in ml_drift Bug: 414868699 Original change's description: > Revert "[dawn][emscripten] Add message argument to QueueWorkDoneCallback" > > This reverts commit f6d857e. > > Reason for revert: blocking Dawn -> chromium roll > > Bug: 414868699 > Original change's description: > > [dawn][emscripten] Add message argument to QueueWorkDoneCallback > > > > Following upstream webgpu.h change: > > webgpu-native/webgpu-headers#528 > > > > Bug: 414868699 > > Change-Id: Ieaf72cd4a295d60659d0cdc20f1e0f95ff054684 > > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/243697 > > Reviewed-by: Loko Kung <lokokung@google.com> > > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > > TBR=kainino@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 414868699 > Change-Id: I88c130ea80884d9e2eada2ce274b276d13f52553 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/244594 > Reviewed-by: Shrek Shao <shrekshao@google.com> > Reviewed-by: James Price <jrprice@google.com> > Reviewed-by: Loko Kung <lokokung@google.com> > Commit-Queue: James Price <jrprice@google.com> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> # Not skipping CQ checks because this is a reland. Bug: 414868699 Change-Id: I4ebfe09041dbad9f0af8585dbdcc1612e4951212 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/244654 Reviewed-by: Loko Kung <lokokung@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #525
(dawn issue https://crbug.com/413427420)