Make <input> close <option> and <optgroup>#52511
Merged
Merged
Conversation
Based on feedback in the <select> parser relaxation HTML spec PR, we might want to close the <select> on these tags when parsing an <input>: whatwg/html#10557 (comment) If the UseCounter shows that usage is low enough, then we could remove this behavior. Bug: 402429384 Change-Id: Id8809d40162c7fd06a446e146d65aaf6258d2e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506819 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1459707}
wpt-pr-bot
approved these changes
May 13, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback in the <select> parser relaxation HTML spec PR, we
might want to close the <select> on these tags when parsing an <input>:
whatwg/html#10557 (comment)
If the UseCounter shows that usage is low enough, then we could remove
this behavior.
Bug: 402429384
Change-Id: Id8809d40162c7fd06a446e146d65aaf6258d2e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506819
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1459707}