ci: replace local hidden-unicode lint with weaviate composite action#334
Draft
mpartipilo wants to merge 1 commit intomainfrom
Draft
ci: replace local hidden-unicode lint with weaviate composite action#334mpartipilo wants to merge 1 commit intomainfrom
mpartipilo wants to merge 1 commit intomainfrom
Conversation
Delegates the trojan-source / hidden-unicode scan to the reusable weaviate/weaviate/.github/actions/security-lint composite action shipped in weaviate/weaviate#11093, pinned to its merge commit (3e52fc80a244f4644d4facc6a4e705ea6eda9039). Removes tools/linter_hidden_unicode.sh — the bash now lives upstream in the composite, so all clients share one implementation. Uses pull_request_target so the workflow definition runs from the base branch and PR-controlled refs are never executed; the composite fetches the diff via the GitHub API.
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 39.3%
Weaviate.Client.Analyzers - 0%
Weaviate.Client.VectorData - 50.3%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the local
tools/linter_hidden_unicode.shinvocation with the reusable composite action shipped in weaviate/weaviate#11093 — pinned to the merge commit3e52fc80a244f4644d4facc6a4e705ea6eda9039..github/workflows/pr-security-lint.yamlto callweaviate/weaviate/.github/actions/security-lint@<SHA>tools/linter_hidden_unicode.sh(the bash now lives upstream in the composite)The other Weaviate clients (Python, TypeScript, Go, Java) are picking up the same composite in parallel PRs. Single source of truth across all 5 SDKs.
Security notes
pull_request_targetruns the workflow definition from the base branch, never from the PR.permissions: {}at workflow level;pull-requests: readis the only grant.Tradeoffs of delegating to an upstream composite
Pros
pull_request_targetruns the workflow definition from the base branch and the composite never checks out PR-controlled refs — a malicious PR can't alter the linter that's checking it.permissions: {}at workflow level,pull-requests: readat job level, no secrets referenced.Cons
weaviate/weaviate/.github/actions/security-lintbreaks all 5 clients until the SHA is bumped.pull_request_targetis a foot-gun — a future editor addingref: pull_request.head.shaor referencing a secret would re-introduce the attack surface this design is built to avoid. The file header warns against it, but the discipline lives in the reviewer.weaviate/weaviaterather than this repo, so debugging a false positive requires hopping to another repo to read the script.Test plan
tools/linter_hidden_unicode.shdoesn't break anything else (only the workflow referenced it)🤖 Generated with Claude Code