Skip to content

Clone a specific Git branch#275

Merged
ocean90 merged 4 commits intowearerequired:masterfrom
lloc:feature/git-branch-specifier
Nov 3, 2025
Merged

Clone a specific Git branch#275
ocean90 merged 4 commits intowearerequired:masterfrom
lloc:feature/git-branch-specifier

Conversation

@lloc
Copy link
Copy Markdown
Contributor

@lloc lloc commented Mar 20, 2025

Description

This PR adds support for specifying a custom Git branch when triggering a translation build in Traduttore.

Motivation

Currently, Traduttore assumes that translations are always built from the repository’s default branch. This can be limiting in scenarios where a different branch needs to be translated—for example, feature branches or specific release branches.

@lloc lloc changed the title Allows to clone a specific Git branch Clone a specific Git branch Mar 20, 2025
swissspidy
swissspidy previously approved these changes Apr 3, 2025
Copy link
Copy Markdown
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me 👍 Thanks!

@swissspidy swissspidy added the [Type] Enhancement New functionality label Apr 3, 2025
@swissspidy swissspidy added this to the 4.0.0 milestone Apr 3, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.35%. Comparing base (f445d69) to head (6b44cca).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
inc/Loader/Git.php 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #275      +/-   ##
============================================
+ Coverage     72.24%   72.35%   +0.11%     
- Complexity        0      410     +410     
============================================
  Files            28       28              
  Lines          1250     1248       -2     
============================================
  Hits            903      903              
+ Misses          347      345       -2     
Flag Coverage Δ
feature 12.50% <0.00%> (+0.01%) ⬆️
php 65.13% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lloc
Copy link
Copy Markdown
Contributor Author

lloc commented Oct 28, 2025

Hey @swissspidy, I was wondering what’s still needed to move forward with version 4.0.0. It looks like some issues have been open for quite a while (since 2018–2019), and another PR got some pushback in 2022. A few of the already closed PRs also seem quite relevant, like the one improving PHP 8+ compatibility.

Is there anything I could do to help get things moving again?

@swissspidy
Copy link
Copy Markdown
Collaborator

I'll defer to @ocean90 as the maintainer.

Comment thread inc/Loader/Git.php Outdated
Comment thread inc/Loader/Git.php Outdated
Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
@lloc lloc requested a review from ocean90 November 3, 2025 15:11
@swissspidy
Copy link
Copy Markdown
Collaborator

FWIW I opened #278 to fix the GitHub Actions workflows.

@ocean90 ocean90 merged commit 9ee3c19 into wearerequired:master Nov 3, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants