Changed the _get_blocks() method of block.Blocks()#23
Open
thelabcat wants to merge 2 commits into
Open
Conversation
A multi-block vector slice of World().blocks now properly returns block data instead of inevitably setting it to 0. Tested with Raspberry Jam.
Author
|
#22 is fixed by this change for Raspberry Jam. |
Author
|
Just discovered a major problem resulting from a misunderstanding of which of the separators (comma, and vertical bar) were used for separating block ID and data, and for separating individual blocks from each-other in the returned network transaction. Have edited a fix, successfully tested with Raspberry Jam. |
Author
|
Just tested on vanilla Minecraft Pi Edition v0.1.1-6 and this fix fully functional. It does not break the API (PTL😁). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A multi-block vector slice of World().blocks now properly returns block data instead of inevitably setting it to 0. Tested with Raspberry Jam.