feat(build): support additional build toolchain args#99
Open
brooksmtownsend wants to merge 2 commits intomainfrom
Open
feat(build): support additional build toolchain args#99brooksmtownsend wants to merge 2 commits intomainfrom
brooksmtownsend wants to merge 2 commits intomainfrom
Conversation
Contributor
Absolutely. If a dev wants custom config options, they should specify those with |
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Bailey Hayes <behayes2@gmail.com>
17bd489 to
18a0719
Compare
|
This repository has been merged into wasmCloud/wasmCloud. Please re-open this PR against wasmCloud/wasmCloud:main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR adds the ability to parse any unknown trailing arguments to
wash builddirectly to the underlying build toolchain.For example, when running
wash buildon a Rust project, you can simplywash build --releaseto build the component in release mode.Because of this, I'm strongly leaning towards removing all of the specialized build arguments in the
.wash/config.json, because it's so much more flexible to be able to specify these with the native toolchain. @ricochet thoughts?Related Issues
Release Information
next
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification