Skip to content

prevent flickering windows on Windows by adding DETACHED_PROCESS #11926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
acarl005 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Draft

prevent flickering windows on Windows by adding DETACHED_PROCESS #11926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/command/src/async.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,13 @@ impl Command {
#[cfg(all(windows, not(feature = "test-util")))]
{
use async_process::windows::CommandExt;
use windows::Win32::System::Threading;
// We need to set the `CREATE_BREAKAWAY_FROM_JOB` flag to avoid assigning
// the process to the same Job Object as the Warp process, otherwise the
// process will be killed when the Warp process is killed.
let flags = windows::Win32::System::Threading::CREATE_NO_WINDOW.0
| windows::Win32::System::Threading::CREATE_BREAKAWAY_FROM_JOB.0;
let flags = Threading::CREATE_NO_WINDOW.0
| Threading::DETACHED_PROCESS.0
| Threading::CREATE_BREAKAWAY_FROM_JOB.0;
Comment on lines +107 to +109
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 [SUGGESTION] DETACHED_PROCESS causes Windows to ignore CREATE_NO_WINDOW, so keeping both makes the effective console behavior harder to reason about.

Suggested change
let flags = Threading::CREATE_NO_WINDOW.0
| Threading::DETACHED_PROCESS.0
| Threading::CREATE_BREAKAWAY_FROM_JOB.0;
let flags = Threading::DETACHED_PROCESS.0
| Threading::CREATE_BREAKAWAY_FROM_JOB.0;

inner.creation_flags(flags);
}
Self {
Expand Down
Loading