Skip to content

Fix vref dac0 not enabled #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
e-tinkers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix vref dac0 not enabled #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8586df
fix VREF for DAC0 not enabled bug
e-tinkers Jan 25, 2026
3fc23de
correct typo
e-tinkers Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion software/BatteryCapacityTester.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,9 @@ void DAC_setLoad(uint16_t current) {
DACreference = 0; // start finding best reference
if(current > 3000) current = 3000; // limit current to max 300mA
while(current > DACCUR[DACreference]) DACreference++; // search for best reference
VREF.CTRLA &= 0xf8; // clear reference bits
VREF.CTRLA &= ~VREF_DAC0REFSEL_gm; // clear reference bits
VREF.CTRLA |= DACREF[DACreference]; // set new reference
VREF.CTRLB |= VREF_DAC0REFEN_bm; // enable VREF for DAC0
_delay_us(25); // wait for reference to settle
DAC0.DATA = (uint32_t)255 * current / DACCUR[DACreference]; // set DAC accordingly
}
Expand Down