Open
Conversation
The `startTime` property in Example 146 is missing a terminating Z. This erratum corrects it.
snarfed
approved these changes
Jul 25, 2025
TallTed
reviewed
Jul 27, 2025
| "subject": "http://sally.example.org", | ||
| "relationship": "http://purl.org/vocab/relationship/friendOf", | ||
| "object": "http://matt.example.org", | ||
| "startTime": "2015-04-21T12:34:56Z" |
Member
There was a problem hiding this comment.
It seems odd to me that a friendship is assigned a start time down to the second. Perhaps it could be bumped to the nearest hour or even the nearest day, even if sometimes the nearest minute might be known...
Member
There was a problem hiding this comment.
I think the resolution of startTime in the example is ok down to the second or even microsecond as long as it conforms to the range https://www.w3.org/TR/activitystreams-vocabulary/#dfn-starttime . The value generally reflects the moment that the individual triggers a button while the server minding that the client's clock may not be in sync with server's clock.
That said, a Note or Considerations section could indicate:
- clock sync concern and any changes to the value after server's processing (possible error handling here if the value is beyond an acceptable or meaningful range) - this may need to be a separate issue if not already visited
- privacy concerns with respect to the resolution
csarven
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
startTimeproperty in Example 146 is missing a terminating Z. This erratum corrects it.