Skip to content

refactor(signals, with-collection-service): Update key names#86

Open
Johanneslueke wants to merge 1 commit into
voznik:masterfrom
Johanneslueke:patch-01
Open

refactor(signals, with-collection-service): Update key names#86
Johanneslueke wants to merge 1 commit into
voznik:masterfrom
Johanneslueke:patch-01

Conversation

@Johanneslueke
Copy link
Copy Markdown

replace "signals" key with "computed" key to be type compatible wit the latest ngrx release

SignalStoreFeature<{
    state: ... ,
    signals: ... ,    // old name
   methods: ... 
}>
SignalStoreFeature<{
    state: ... ,
    computed: ... ,    // <--!!! new name
   methods: ... 
}>

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

with the latest release of ngrx the withCollectionService method is type incompatible with the the ngrx "signalStore".

Issue Number: N/A

What is the new behavior?

the "withCollectionService" becomes compatible with the "signalStore" method

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

replace "signals" key with "computed" key to be type compatible wit the latest ngrx release
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant