Skip to content

Regression test for special chars in comments#112

Open
traylenator wants to merge 2 commits intovoxpupuli:masterfrom
traylenator:regexmatch
Open

Regression test for special chars in comments#112
traylenator wants to merge 2 commits intovoxpupuli:masterfrom
traylenator:regexmatch

Conversation

@traylenator
Copy link
Copy Markdown
Contributor

Pull Request (PR) description

Addition of test to trigger problem identified in #95

Without #95 this test fails with:

Failures:

  1) Puppet::Type::Sshd_config_match::ProviderAugeas with condition containing regex chars creates simple new entry
     Failure/Error: expect(againlogs).to eq([]), 'expected no change on second run (idempotence check)'
     
       expected no change on second run (idempotence check)
       Diff:
       @@ -1 +1 @@
       -[]
       +[#<Puppet::Util::Log:0x00007f2fced99f68 @level=:notice, @tags=#<Puppet::Util::TagSet: {"notice", "sshd_config_match"}>, @message="comment changed 'Host *: created by Puppet' to 'created by Puppet'", @source="/Sshd_config_match[Host *]/comment", @time=2024-08-06 09:17:08.781548196 +0200>]
       
     # ./spec/fixtures/modules/augeasproviders_core/spec/lib/augeas_spec/fixtures.rb:46:in `apply!'
     # ./spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb:50:in `block (3 levels) in <top (required)>'

This Pull Request (PR) fixes the following issues

Fixes #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants