New package: rivalcfg-4.17.0

[uggwar]

• I tested the changes in this PR: YES
• This new package conforms to the package requirements: YES
• I built this PR locally for my native architecture, (x86_64-glibc)

[slymattz]

Are you sure it's licensed under Apache-2.0 and not WTFPL? Their github page says it's the latter, in which case, you should probably write WTFPL and do vlicense LICENSE in post_install()

grep -R WTFPL srcpkgs 
srcpkgs/tree-sitter-gitcommit/template:license="WTFPL"
srcpkgs/LGOGDownloader/template:license="WTFPL"
srcpkgs/WindowMaker-devel/template:license="GPL-2.0-or-later, WTFPL"
srcpkgs/WindowMaker-devel/template:     vlicense COPYING.WTFPL
srcpkgs/WindowMaker/template:license="GPL-2.0-or-later, WTFPL"
srcpkgs/WindowMaker/template:   vlicense COPYING.WTFPL
srcpkgs/fcount/template:license="WTFPL"
srcpkgs/gettext-stub-devel/template:license="WTFPL"
srcpkgs/gettext-stub/template:license="WTFPL"
srcpkgs/gohufont/template:license="WTFPL"
srcpkgs/hxtools/template:license="WTFPL AND LGPL-2.0-or-later AND GPL-2.0-or-later"
srcpkgs/hydrus/template:license="WTFPL"
srcpkgs/libcaca-devel/template:license="WTFPL"
srcpkgs/libcaca/template:license="WTFPL"
srcpkgs/lolcat-c/template:license="WTFPL"
srcpkgs/orjail/template:license="WTFPL"
srcpkgs/skroll/template:license="WTFPL"
srcpkgs/toilet/template:license="WTFPL"
srcpkgs/wifish/template:license="WTFPL"
srcpkgs/xcmenu/template:license="WTFPL"
srcpkgs/zimg-devel/template:license="WTFPL"
srcpkgs/zimg/template:license="WTFPL"
srcpkgs/zzuf/template:license="WTFPL"

[uggwar]

Auch, you are correct. Missed that one! Thanks, will fix tonight!

[ahesford]

We don't vendor content like those udev rules, especially when they can be automatically generated by the program.

[ahesford]

What are these tests? https://github.com/flozz/rivalcfg/tree/master/test

[uggwar]

I used another project as a template and this slipped through. Will remove and test!

[ahesford]

Fetching from $PYPI_SITE should be preferred, unless the GitHub tarball offers content (like tests) that are not shipped in the PyPI distribution.

[uggwar]

Thanks, didn't know. Will change this and see how it goes.

[uggwar]

I really hate that hard coded path for the udev rules that it checks every time it runs. I removed the patch that changes this path, since it probably is better to just go with the application defaults. What do you think?