zoom: update to 7.0.5.3034#60552
Conversation
ahesford
left a comment
There was a problem hiding this comment.
None of these invocations of rm should use the -f flag. It masks changes to file structures that should be made obvious by a failure to build.
Thank-you for the review. |
|
I cannot find the missing returns no result |
zoom seems to ship only half of qt6 libraries its using. They ship |
|
FYI, I had bumped the version of Zoom to 7.0.5 since it's the latest version. 7.0.5 still doesn't contain Let me know if there's anything else I should do to get this PR merged. Someone confirmed they tested the changes successfully at #60526 |
|
Tested zoom-7.0.5.3034 with this patch on Void Linux x86_64. All good. libQt6Bodymovin.so.6 resolves cleanly. |
| build_options="systemqt" | ||
| desc_option_systemqt="Use system QT libraries" |
There was a problem hiding this comment.
skiprdeps should be a much cleaner option in this case. A quick ldd reveals the culprit library.
/opt/zoom/Qt/qml/Qt/labs/lottieqt/liblottieqtplugin.so
Removing bundled libraries from a proprietary package is usually unsupported by upstream and might have unintended breakages down the line. For my instance, calendar, tasks and some other tabs refused to load:
24: loadZoomWebviewHostProcess newPath is /opt/zoom/ZoomWebviewHost
25: Qt library path does not exist: /opt/zoom/Qt/lib
26: zoom loadZoomWebviewHostProcess failed.
Creating /opt/zoom/Qt/lib manually indeed fixed the issue.
This is the current template I'm using, works fine with and without systemqt.
# Template file for 'zoom'
pkgname=zoom
version=7.0.5.3034
revision=1
archs="x86_64"
create_wrksrc=yes
depends="libglvnd pulseaudio-utils"
short_desc="Video Conferencing and Web Conferencing Service"
maintainer="Orphaned <orphan@voidlinux.org>"
license="custom:Proprietary"
homepage="https://zoom.us/"
distfiles="https://cdn.zoom.us/prod/${version}/zoom_x86_64.rpm"
checksum=f11f0c4bea9236b5d89842be532e8dfdb1e61c92416461f5cae02ec0f7224a24
repository=nonfree
noshlibprovides=yes
skiprdeps="/opt/zoom/Qt/qml/Qt/labs/lottieqt/liblottieqtplugin.so"
restricted=yes
nopie=yes
build_options="systemqt"
desc_option_systemqt="Use system QT libraries"
if [ "$build_option_systemqt" ]; then
make_dirs="/opt/zoom/Qt/lib 0755 root root"
fi
pre_install() {
if [ "$build_option_systemqt" ]; then
rm -r opt/zoom/Qt
rm opt/zoom/libquazip.so
rm opt/zoom/libmpg123.so
rm opt/zoom/libKF6GlobalAccel.so.6
rm opt/zoom/qt.conf
fi
}
do_install() {
vcopy "*" /
vlicense ${FILESDIR}/DISTRIBUTION-DETAILS
}There was a problem hiding this comment.
Thank you for the updated patch @mnabid.
I tested it and it works with and without the systemqt option.
I have updated the patch.
Testing the changes
Closes #60526
libQt6Bodymovin.sowas required by the non-systemqtbuild of zoom. This seems to be a new dependency not present in previous versions.Unfortunately because Zoom 7.0.0 doesn’t ship
libQt6Bodymovin.so, therefor the new Zoom version was broken with the most recentqt6-lottie.This PR removes the
systemqtoption and forces Zoom to use the system’s Qt6. I don’t think there is much value in using Zoom’s own Qt6 libraries anyway. It also removes the outdatedrm -rf ...calls, since most of these files are not in the Zoom 7.0.0 and 7.0.5 RPM.Local build testing