Skip to content

vscode: update to 1.99.3#54742

Merged
classabbyamp merged 1 commit into
void-linux:masterfrom
atk:vscode-1.98.0
May 7, 2025
Merged

vscode: update to 1.99.3#54742
classabbyamp merged 1 commit into
void-linux:masterfrom
atk:vscode-1.98.0

Conversation

@atk

@atk atk commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

I get the error message

Error [ERR_WORKER_OUT_OF_MEMORY]: Worker terminated due to reaching memory limit: JS heap out of memory

probably due to my personal system being limited to 8GB of RAM.

Update: I had to change a few bits, but I finally fixed the build. It now requires 16GB at least (using swap works fine, but slows things down considerably).

@atk atk marked this pull request as ready for review March 18, 2025 14:10
@icp1994

icp1994 commented Mar 18, 2025

Copy link
Copy Markdown
Member

No way vscode would mandate 16GB RAM as minimum system requirement!

@atk

atk commented Mar 18, 2025

Copy link
Copy Markdown
Contributor Author

Not during run-, but during compile time...

@classabbyamp

Copy link
Copy Markdown
Member

what if we disable parallel build? is it even doing things in parallel?

@atk

atk commented Mar 18, 2025

Copy link
Copy Markdown
Contributor Author

Workers are the JS version of threads, so it is safe to assume that stuff runs in parallel. However, running it parallel should reduce the build time in CI.

@atk atk changed the title vscode: update to 1.98.2 vscode: update to 1.99.3 Apr 30, 2025
@atk

atk commented May 5, 2025

Copy link
Copy Markdown
Contributor Author

Calling gulp with --series, --optimize-for-size and setting the RAM limit to 16GB ensured a working build for me.

@classabbyamp

Copy link
Copy Markdown
Member

please squash the commits

@atk atk force-pushed the vscode-1.98.0 branch from 61441c4 to dc0615a Compare May 7, 2025 18:54
@atk

atk commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

Done.

@classabbyamp classabbyamp merged commit 6178c49 into void-linux:master May 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants