Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

patch to overload LB port on reconciliation loop - #584

Open
Maellooou wants to merge 1 commit into
vmware-archive:mainfrom
Maellooou:main
Open

patch to overload LB port on reconciliation loop#584
Maellooou wants to merge 1 commit into
vmware-archive:mainfrom
Maellooou:main

Conversation

@Maellooou

@Maellooou Maellooou commented Jan 18, 2024

Copy link
Copy Markdown

Description

Please provide a brief description of the changes proposed in this Pull Request

  • The variable controlPlanePort is reset at default value at each loop. Use the vcdCluster.Spec.ControlPlaneEndpoint.Port value if it is defined

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #
Fixe bug #583


This change is Reviewable

@vmwclabot

Copy link
Copy Markdown

@Maellooou, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot

Copy link
Copy Markdown

@Maellooou, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot

Copy link
Copy Markdown

@Maellooou, VMware has approved your signed contributor license agreement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants