Skip to content

Use bootstrap 5.3.1 for js-console-validation-result-table attachment#6676

Open
uarlouski wants to merge 1 commit into
masterfrom
vividus-plugin-web-app
Open

Use bootstrap 5.3.1 for js-console-validation-result-table attachment#6676
uarlouski wants to merge 1 commit into
masterfrom
vividus-plugin-web-app

Conversation

@uarlouski

@uarlouski uarlouski commented Jun 5, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Upgraded the app's styling framework to a newer version for improved browser compatibility and visuals.
  • Style
    • Updated warning and severe table row styling to follow the updated styling system, ensuring more consistent, accessible colors and appearance.

@uarlouski uarlouski requested a review from a team as a code owner June 5, 2026 08:42
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 15b2851b-8235-414d-857f-569fb3e9733b

📥 Commits

Reviewing files that changed from the base of the PR and between 4323147 and c711f3e.

📒 Files selected for processing (1)
  • vividus-plugin-web-app/src/main/resources/org/vividus/steps/ui/web/js-console-validation-result-table.ftl

📝 Walkthrough

Walkthrough

Updates the FreeMarker JS console validation result template: the Bootstrap stylesheet link is changed from 3.4.1 to 5.3.1 and SEVERE/WARNING row CSS now uses Bootstrap 5 table CSS variables.

Changes

Bootstrap CSS Version Update

Layer / File(s) Summary
Bootstrap stylesheet reference update
vividus-plugin-web-app/src/main/resources/org/vividus/steps/ui/web/js-console-validation-result-table.ftl
The HTML <link> element for Bootstrap CSS is updated to load version 5.3.1 from webjars instead of 3.4.1.
Row styling switched to Bootstrap 5 variables
vividus-plugin-web-app/src/main/resources/org/vividus/steps/ui/web/js-console-validation-result-table.ftl
.SEVERE and .WARNING CSS now use --bs-table-bg and --bs-table-color variables rather than direct background-color/color declarations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • vividus-framework/vividus#6675: Both PRs update the same kind of FreeMarker UI template to use Bootstrap 5.3.1 and adjust table styling to Bootstrap 5 conventions (theme/variables vs Bootstrap 3 classes).
  • vividus-framework/vividus#6672: Both PRs update FreeMarker result-table templates to switch Bootstrap dependencies from 3.4.1 to 5.3.1 (including related table styling class/CSS adjustments).
  • vividus-framework/vividus#6674: Both PRs update FreeMarker templates in the web app to switch Bootstrap assets from 3.4.1 to Bootstrap 5.3.1 (including related table styling/classes).
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: upgrading Bootstrap from 3.4.1 to 5.3.1 in a specific FreeMarker template file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vividus-plugin-web-app

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.79%. Comparing base (3474c94) to head (c711f3e).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6676   +/-   ##
=========================================
  Coverage     97.79%   97.79%           
  Complexity     7325     7325           
=========================================
  Files          1015     1015           
  Lines         21508    21508           
  Branches       1416     1416           
=========================================
  Hits          21033    21033           
  Misses          359      359           
  Partials        116      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@uarlouski uarlouski force-pushed the vividus-plugin-web-app branch from 4439ce6 to 4323147 Compare June 8, 2026 07:54
@uarlouski uarlouski force-pushed the vividus-plugin-web-app branch from 4323147 to c711f3e Compare June 8, 2026 14:19
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant