Typing fixes for options and Graph2d#1750
Open
jan-dolejsi wants to merge 5 commits into
Open
Conversation
…into typing_fixes_for_options_and_graph2d
mojoaxel
requested changes
Dec 3, 2025
Comment on lines
+547
to
+552
| /** | ||
| * Retrieve legend icon (SVG, name and y-axis affiliation) | ||
| * @param groupId group id for which the legend icon and name should be returned | ||
| * @param iconWidth icon width | ||
| * @param iconHeight icon height | ||
| */ |
Member
There was a problem hiding this comment.
jsdocs make not much sense in type definition files. Please remove or replace with a one-line comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graph2dOptions(matching the documentation and examples)Graph2d.getLegend(...)typingsTimelineOptions.loadingScreenTemplate