Invoke set range callback always and pass info about change#1703
Open
zanella wants to merge 2 commits into
Open
Invoke set range callback always and pass info about change#1703zanella wants to merge 2 commits into
zanella wants to merge 2 commits into
Conversation
added 2 commits
October 23, 2023 15:36
- The callback is alwys invoked - The callback now receives a parameter telling if a change has taken place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback on zoomIn/zoomOut are only invoked inside setRange() when there's an actual change.
This makes it hard to decide what to do when using said functions (e.g. disable the zoom button if the max has been reached)
This change makes the button always be called, and to receive a new parameter, telling if a range change happened or not.
The linter pattern was not working (mac OS / zsh), now it is (
npm run lint), but there are 78 problems 😅