Skip to content

fixed filename being lost on routing to root #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NikanV wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fixed filename being lost on routing to root #614

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
019b105
fixed filename getting lost
NikanV Jun 27, 2023
902e792
Merge pull request #1 from NikanV/fixing-filename-lost
NikanV Jun 27, 2023
84b994e
fixed the click handler file
NikanV Jun 27, 2023
15c6016
Merge pull request #2 from NikanV/fixing-filename-lost
NikanV Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ pathToRegexp_1.tokensToRegExp = tokensToRegExp_1;
// rebuild path
// There aren't .pathname and .search properties in svg links, so we use href
// Also, svg href is an object and its desired value is in .baseVal property
var path = svg ? el.href.baseVal : (el.pathname + el.search + (el.hash || ''));
var path = svg ? el.href.baseVal : location.href.substring(location.href.lastIndexOf("/"));

path = path[0] !== '/' ? '/' + path : path;

Expand Down Expand Up @@ -1128,7 +1128,7 @@ pathToRegexp_1.tokensToRegExp = tokensToRegExp_1;
Context.prototype.save = function() {
var page = this.page;
if (hasHistory) {
page._window.history.replaceState(this.state, this.title,
page._window.history.pushState(this.state, this.title,
page._hashbang && this.path !== '/' ? '#!' + this.path : this.canonicalPath);
}
};
Expand Down