Normalize the way to get the URL in case that path is not provided.#310
Open
jorgecasar wants to merge 2 commits into
Open
Normalize the way to get the URL in case that path is not provided.#310jorgecasar wants to merge 2 commits into
jorgecasar wants to merge 2 commits into
Conversation
|
Great! thx @jorgecasar! Please, this pull request is urgent for us... |
5423b1e to
4d18aec
Compare
4d18aec to
ba30c47
Compare
Collaborator
|
Can you explain what this fixes? |
Contributor
Author
|
There are 3 places in the code where the path is managed. And each part get it with different approach. This commit try to normalize and always get the path following the same rules. Sometimes you lost url info because of the parsers. The correct one is the Approach 1, the other cause errors because of the search info and hashbang. Approach 1: Approach 2: Approach 3: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solve the error that happens when application runs in root path (
location.pathname === '/') and navigate using anchor link. There was 2 diferent ways to generate the URL, one forpage.startand other for cases whenevent.stateis not provided onpopstateevent.