Skip to content

Fix command-line SKK cancel flow so <Esc>/<C-g> abort composition instead of confirming #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shougo merged 2 commits into from
May 10, 2026
Merged

Fix command-line SKK cancel flow so <Esc>/<C-g> abort composition instead of confirming #269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fca08ef
Initial plan
Copilot May 10, 2026
c1b2de0
fix: cancel command-line SKK composition on Esc/C-g
Copilot May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions autoload/eskk.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,11 @@ function! s:asym_filter(stash) abort "{{{
call s:do_cancel(a:stash)
return
elseif char ==# "\<Esc>"
call s:do_escape(a:stash)
if mode() ==# 'c' && !preedit.empty()
call s:do_cancel(a:stash)
else
call s:do_escape(a:stash)
endif
return
endif

Expand Down Expand Up @@ -770,7 +774,9 @@ endfunction "}}}
function! s:do_cancel(stash) abort "{{{
let preedit = a:stash.preedit
if mode() ==# 'c'
call preedit.push_filter_pre_char("\<Esc>")
call preedit.set_henkan_phase(g:eskk#preedit#PHASE_NORMAL)
call preedit.clear_all()
call preedit.push_filter_post_char("\<Esc>")
else
call preedit.set_henkan_phase(g:eskk#preedit#PHASE_NORMAL)
call preedit.clear_all()
Expand Down
Loading