Skip to content

fix(deps): update picomatch (medium)#896

Open
claude[bot] wants to merge 1 commit intomainfrom
claude/dependabot-sweep-picomatch
Open

fix(deps): update picomatch (medium)#896
claude[bot] wants to merge 1 commit intomainfrom
claude/dependabot-sweep-picomatch

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude bot commented Apr 13, 2026

Summary

  • Update transitive dependency picomatch from 2.3.1 to 2.3.2 to resolve GHSA-3v7f-55p6-f55p (CVE-2026-33672, medium severity)
  • The vulnerability involves method injection in POSIX character classes causing incorrect glob matching
  • Only lockfiles modified — no code or manifest changes required since picomatch is a transitive dependency and existing semver ranges already allow 2.3.2

Lockfiles modified

  • package-lock.json
  • examples/connect-app-teleop-react/package-lock.json
  • examples/node/package-lock.json
  • examples/teleop-react/package-lock.json

Advisories resolved

Unresolved alerts

None — all alerts resolved.

Resolves #893

🤖 Generated with Claude Code

Update transitive dependency picomatch from 2.3.1 to 2.3.2 across all
affected lockfiles to resolve CVE-2026-33672 (method injection in POSIX
character classes causing incorrect glob matching).

Resolves #893

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude claude bot requested a review from a team as a code owner April 13, 2026 09:46
@claude claude bot requested review from allisonschiang and lia-viam April 13, 2026 09:46
Copy link
Copy Markdown
Contributor Author

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: fix(deps): update picomatch (medium)

This PR correctly patches GHSA-3v7f-55p6-f55p by bumping picomatch from 2.3.1 → 2.3.2 across all affected lockfiles.

What looks correct

  • All 4 lockfiles update node_modules/picomatch to 2.3.2.
  • The semver ranges (^2.3.1) in dependents already allow 2.3.2 — no manifest change needed.
  • The resolved URL and integrity hash (sha512-V7+vQEJ06Z+c5tSye8S+nHUfI51xoXIXjHQ99cQtKUkQqqO1kO/KCJUfZXuB47h/YBlDhah2H3hdUGXn8ie0oA==) are consistent across all 4 lockfiles.
  • src/gen/ is untouched.
  • No source files or manifests (package.json) were modified.
  • The examples/react-native lockfile was already at picomatch 2.3.2 and was correctly left alone.

Incidental lockfile drift (not a blocker)

The example lockfiles were fully regenerated rather than surgically patched (which is normal npm install behavior). This pulled in two additional changes not mentioned in the PR description:

  1. SDK version references in example lockfiles updated from stale values (0.66.1 / 0.68.1) to the current release (0.68.2). This is correct — the lockfiles were behind.
  2. flatted ^3.4.2 appears in the devDependencies metadata block for the parent package in examples/node and examples/teleop-react lockfiles. Confirmed that flatted was already added to the root package.json (line 80), so this is the lockfiles catching up to the current manifest.

These changes are all correct and benign — they reflect the true current state of the package. The PR description could be more precise ("lockfile regeneration picked up additional drift"), but this is documentation-only and not a code issue.

Verdict

The security fix is correct and complete. No issues requiring changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(deps): update picomatch (medium, 4 alerts)

0 participants