Conversation
uuid is a transitive dependency of vite-plugin-devtools-json, which has no version that depends on uuid>=14.0.0. Added pnpm override to force the patched version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
There was a problem hiding this comment.
Review: fix(deps): update uuid (medium)
This is a correct, minimal security override. No blocking issues.
What was reviewed:
package.json: newpnpm.overridesblock forcinguuidto>=14.0.0pnpm-lock.yaml: uuid upgraded from11.1.0→14.0.0in both the resolution and snapshot sections
Findings:
✅ Override placement is correct. pnpm.overrides is the right mechanism here — vite-plugin-devtools-json@1.0.0 pins uuid@^11.1.0 with no released version that pulls >=14.0.0, so an override is the only option short of forking the plugin.
✅ Lockfile is consistent. All three locations in pnpm-lock.yaml are updated (overrides block, packages section, and the vite-plugin-devtools-json snapshot). uuid@14.0.0 has no transitive dependencies ({}), so there's no hidden dependency churn.
✅ Scope is correct. uuid-tool@2.0.3 (a completely separate package used by @viamrobotics/prime-core) is untouched.
✅ Change is minimal. No source files, no tests, no config files other than what's required.
Minor observation (non-blocking): The range >=14.0.0 is wide — a future pnpm update uuid could install uuid@15+ which may have breaking changes. ^14.0.0 would be more conservative. In practice the lockfile pins 14.0.0 so this only matters on an explicit pnpm update, and the PR description already notes the override should be removed when vite-plugin-devtools-json ships a compatible version. Acceptable as-is.
Summary
uuidto>=14.0.0viapnpm.overridesto resolve GHSA-w5hq-g745-h8pq (medium severity: missing buffer bounds check in v3/v5/v6 when buf is provided)uuidis a transitive dependency ofvite-plugin-devtools-json@1.0.0, which depends onuuid@^11.1.0. No version ofvite-plugin-devtools-jsonexists that pulls inuuid@>=14.0.0, so a pnpm override was required as a last resort.vite-plugin-devtools-jsonreleases a version that depends onuuid@>=14.0.0.Advisories resolved
Lockfiles modified
pnpm-lock.yamlUnresolved alerts
None — all alerts resolved.
Test plan
pnpm installsucceedspnpm buildsucceedspnpm why uuidconfirmsuuid@14.0.0Resolves #42