Add Windows CLI feature parity with Unix installer#3617
Open
dimension-zero wants to merge 1 commit into
Open
Conversation
42e0dc0 to
054855f
Compare
…, /Label
The Windows VTOYCLI mode was built as a silent GUI web-server backend and
lacked the interactive and informational features of the Unix CLI. This commit
adds full feature parity:
- /HELP and /?: print usage to the console and exit 0
- /V: print the local Ventoy version (from ventoy\version) and exit 0
- /L: list Ventoy version, partition style, secure boot, filesystem, disk
size and bus type for the selected drive (read-only, no changes made)
- /SI: safe install — refuses if Ventoy is already present; prompts for
confirmation twice before writing (suppressed with /Y)
- /SB: explicitly enable secure boot support (mirrors Unix -s flag)
- /Y: auto-confirm prompts for scripted/silent use
- /Label:NAME: set the volume label for partition 1 (default: Ventoy);
propagated through all four DiskService backends
Console output: AttachConsole + _open_osfhandle so printf works from both
interactive cmd.exe sessions and PowerShell pipe capture (> file, $(...)).
WinDialog: /HELP, /?, /V and /L skip the boot-file presence check so they
work from any directory; other CLI write operations log the error instead
of showing a MessageBox.
DOC/Windows_CLI.txt: new user-facing documentation with examples and a
Unix-to-Windows flag mapping table.
054855f to
9444e82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the Windows `Ventoy2Disk.exe VTOYCLI` mode up to feature parity with the existing Unix CLI installer (`Ventoy2Disk.sh`).
Before this change, `VTOYCLI` was only used silently by the Windows GUI as a web-server backend and lacked the interactive/informational flags that the Unix CLI already supports.
Flags added
Plumbing notes
Stats
Test plan