Skip to content

fix(dashboard): show loading indicator when uploading assets #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
latifniz wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −3
Open

fix(dashboard): show loading indicator when uploading assets #4940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions packages/dashboard/src/lib/components/shared/asset/asset-gallery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export function AssetGallery({

const assets = (data?.assets.items ?? []) as Asset[];

const { mutate: createAssets } = useMutation({
const { mutate: createAssets, isPending: isUploading } = useMutation({
mutationFn: api.mutate(createAssetsDocument),
onSuccess: () => {
queryClient.invalidateQueries({ queryKey });
Expand Down Expand Up @@ -402,8 +402,13 @@ export function AssetGallery({
)}
<PageActionBar>
<ActionBarItem itemId="upload-assets-button">
<Button onClick={openFileDialog} className="whitespace-nowrap">
<Upload className="h-4 w-4 mr-2" /> <Trans>Upload</Trans>
<Button onClick={openFileDialog} disabled={isUploading} className="whitespace-nowrap">
{isUploading ? (
<Loader2 className="h-4 w-4 mr-2 animate-spin" />
) : (
<Upload className="h-4 w-4 mr-2" />
)}
<Trans>Upload</Trans>
</Button>
</ActionBarItem>
</PageActionBar>
Expand Down Expand Up @@ -439,6 +444,13 @@ export function AssetGallery({
</div>
)}

{isUploading && (
<div className="absolute inset-0 bg-background/70 backdrop-blur-sm z-10 flex flex-col items-center justify-center rounded-md">
<Loader2 className="h-10 w-10 text-primary animate-spin mb-3" />
<p className="text-center font-medium"><Trans>Uploading assets...</Trans></p>
</div>
)}

{viewMode === 'list' ? (
<AssetListView
assets={assets}
Expand Down
Loading