-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: pass nullable into many-to-one custom relations #4895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LucidityDesign
wants to merge
15
commits into
vendurehq:minor
Choose a base branch
from
LucidityDesign:feat/nullable-relations
base: minor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
11efec5
feat(core): Extend custom relational field config
LucidityDesign 7cda07e
docs(core): Document new custom field properties
LucidityDesign 8575c09
refactor: Remove meaningless nullable
LucidityDesign 3608d50
chore: Warn about potential uninentional side effects when using onDe…
LucidityDesign 8ea1ac0
docs: Document side effect of onDelete: CASCADE
LucidityDesign f179f33
refactor: Remove unused var
LucidityDesign 2c1846a
test: Test custom entity options for relational fields
LucidityDesign 9f1cd86
docs: Improve onDelete documentation
LucidityDesign 8ad247a
refactor: Improve onDelete warning
LucidityDesign a7c9319
docs: fix, default and example
LucidityDesign f5c3f28
feat: revert passing in nullable due to changing behavior
LucidityDesign 3d316ba
test: extend tests to cover onDelete and cascade warning
LucidityDesign 1f6f005
fix: warn condition, add test cases
LucidityDesign 9949753
docs: build docs
LucidityDesign ee213d3
feat: pass nullable into many-to-one custom relations
LucidityDesign File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is overkill, but I find it useful to disallow options that will be ignored