docs(integrations): drop removed 'opinion' fact type from recall_types/fact_types across SDK wrappers#2335
Open
r266-tech wants to merge 1 commit into
Conversation
…s/fact_types The 'opinion' fact type was removed in v0.8.0 (vectorize-io#1917). The recall API now rejects it: - response_models.py: VALID_RECALL_FACT_TYPES = frozenset(['world', 'experience', 'observation']) - http.py (recall + reflect): fact_types: list[Literal['world', 'experience', 'observation']] | None - models.py: CheckConstraint("fact_type IN ('world', 'experience', 'observation')") Ten integration SDK packages still advertised 'opinion' as a valid recall_types/fact_types value in public tool docstrings, one inline comment, and two README tables, so an agent copying them passes a value the API 422-rejects. Completes the ripple started by vectorize-io#2198 / vectorize-io#2302 / vectorize-io#2323 across the hindsight-integrations/* tail (text only, no logic change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
opinionwas removed as a valid fact type in v0.8.0 (#1917), but ten integration SDK packages still advertise it as a validrecall_types/fact_typesvalue in their public tool docstrings, one inline comment, and two README tables. An agent (or developer) copying these passes a value the recall API now hard-rejects.Canonical truth on
main:hindsight-api-slim/hindsight_api/engine/response_models.py:VALID_RECALL_FACT_TYPES = frozenset(["world", "experience", "observation"])hindsight-api-slim/hindsight_api/api/http.py(recall + reflect):fact_types: list[Literal["world", "experience", "observation"]] | None→ Pydantic rejectsopinionat request parse (422)hindsight-api-slim/hindsight_api/models.py:CheckConstraint("fact_type IN ('world', 'experience', 'observation')")Change
Drop
opinionfrom the fact-type enumeration in the integration wrappers — docstrings, one inline comment, and two README tables. Text only, no logic change:hindsight_ag2/tools.pyhindsight_langgraph/tools.py,nodes.pyhindsight_claude_agent_sdk/tools.pyhindsight_openai_agents/tools.py,README.mdhindsight_llamaindex/tools.py(×2)hindsight_autogen/tools.py,README.mdhindsight_google_adk/tools.pyhindsight_continue/config.pyhindsight_haystack/tools.pyhindsight_litellm/config.py(×4)This completes the sweep started by #2198 (litellm docs), #2302 (MCP + quickstart), and #2323 (python-client) — none of which touched
hindsight-integrations/*.Notes
hindsight-integrations/*is outside thegenerate-docs-skill.sh/generate-clients.shinputs, soverify-generated-filesis unaffected; the edits are docstring / comment / markdown only and ruff-clean.hindsight-api-slim/.../response_models.pystill referencesopinionin aField(description=...)and a"opinion": []default — those live in the API package, not the integration wrappers.