Skip to content

fix(claude-code): use realpath for directoryBankMap symlink resolution #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
365diascollaboration-prog wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −2
Open

fix(claude-code): use realpath for directoryBankMap symlink resolution #2324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0078d
fix(claude-code): use realpath for directoryBankMap symlink resolution
365diascollaboration-prog Jun 19, 2026
b9863ab
test(claude-code): add symlink regression test for directoryBankMap
365diascollaboration-prog Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hindsight-integrations/claude-code/scripts/lib/bank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ def derive_bank_id(hook_input: dict, config: dict) -> str:
# case-sensitive compare silently misses the map and falls through
# to the default bank. normcase is a no-op on POSIX, preserving
# case-sensitive matching there.
normalized_cwd = os.path.normcase(os.path.normpath(cwd))
normalized_cwd = os.path.normcase(os.path.realpath(cwd))
for dir_path, bank_id in dir_map.items():
if os.path.normcase(os.path.normpath(dir_path)) == normalized_cwd:
if os.path.normcase(os.path.realpath(dir_path)) == normalized_cwd:
return f"{prefix}-{bank_id}" if prefix else bank_id

if not config.get("dynamicBankId", False):
Expand Down
11 changes: 11 additions & 0 deletions hindsight-integrations/claude-code/tests/test_bank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,3 +296,14 @@ def test_different_banks_each_set_once(self, state_dir):
ensure_bank_mission(client, "bank-x", cfg)
ensure_bank_mission(client, "bank-y", cfg)
assert client.set_bank_mission.call_count == 2

@pytest.mark.skipif(not hasattr(__import__("os"), "symlink"), reason="symlinks not supported")
def test_directorybankmap_matches_symlinked_cwd(self, tmp_path):
import os
real = os.path.realpath(tmp_path / "proj")
os.makedirs(real)
link = str(tmp_path / "proj-link")
os.symlink(real, link)
cfg = _cfg(directoryBankMap={real: "myproj"}, bankId="fallback")
assert derive_bank_id({"cwd": real, "session_id": "s"}, cfg) == "myproj"
assert derive_bank_id({"cwd": link, "session_id": "s"}, cfg) == "myproj"