fix(recall): allow exact filtering of untagged observations (#2295)#2322
Open
wangzupeng12061 wants to merge 1 commit into
Open
fix(recall): allow exact filtering of untagged observations (#2295)#2322wangzupeng12061 wants to merge 1 commit into
wangzupeng12061 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2295.
Allow recall to select only global/untagged observations by using an empty tag
set with
tags_match="exact".This enables users to switch between shared observations and tagged observation
scopes without adding a synthetic "global" tag or maintaining negative filters.
Root cause
The centralized tag filters treated
Noneand[]as "no filter" beforechecking the matching mode.
As a result:
This contradicted the existing scope semantics where the empty tag set
represents the global observation scope.
Fix
exactmode.NULLtags and current empty-array tags.no bind parameter.
compound tag groups.
filtering for
any,all,any_strict, andall_strict.Tests
Added regression coverage for:
Noneand[];memory.
Verification
Run on Linux x86_64 with Python 3.11, Node.js 22, and PostgreSQL 17 + pgvector:
91 passed-tests/test_tags_visibility.py10 passed-tests/test_graph_filtering.pyty check hindsight_apipassed./scripts/hooks/lint.shpassed