Skip to content

test(backups): more tests#9675

Open
fbeauchamp wants to merge 4 commits intomasterfrom
test_replication
Open

test(backups): more tests#9675
fbeauchamp wants to merge 4 commits intomasterfrom
test_replication

Conversation

@fbeauchamp
Copy link
Copy Markdown
Collaborator

@fbeauchamp fbeauchamp commented Apr 3, 2026

Description

  • ensure merge are done synchronously
  • ensure the temp remote are really empty before starting
  • tests incremental ( symmetrical) replication
  • test full mirror backup

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@fbeauchamp fbeauchamp marked this pull request as ready for review April 3, 2026 12:33
@fbeauchamp fbeauchamp requested a review from mpiton April 3, 2026 12:36
Copy link
Copy Markdown
Collaborator

@mpiton mpiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tests are a bit fragile imo : the fallback in countVmBackups silently picks the first key if the repo ID doesn't match, which can hide real issues. And the delta transfer size assertion in CR mode will break if the VM has any I/O between runs. Not blocking, we can harden these later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants