Skip to content

dict: remove dict/dictType/dictIterator typedefs, use hashtable types…

d507179
Select commit
Loading
Failed to load commit list.
Draft

draft: make dict a fully concrete, transparent set of map helpers for hashtable, removing dict elements where redundant #3720

dict: remove dict/dictType/dictIterator typedefs, use hashtable types…
d507179
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 15, 2026 in 0s

76.68% (+0.03%) compared to fdf13ca

View this Pull Request on Codecov

76.68% (+0.03%) compared to fdf13ca

Details

Codecov Report

❌ Patch coverage is 68.61314% with 129 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.68%. Comparing base (fdf13ca) to head (d507179).

Files with missing lines Patch % Lines
src/sentinel.c 0.00% 85 Missing ⚠️
src/valkey-cli.c 61.90% 16 Missing ⚠️
src/module.c 74.28% 9 Missing ⚠️
src/fuzzer_command_generator.c 66.66% 3 Missing ⚠️
src/valkey-benchmark.c 25.00% 3 Missing ⚠️
src/cluster.c 71.42% 2 Missing ⚠️
src/cluster_legacy.c 96.77% 2 Missing ⚠️
src/config.c 88.88% 2 Missing ⚠️
src/rdb.c 77.77% 2 Missing ⚠️
src/server.c 90.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #3720      +/-   ##
============================================
+ Coverage     76.65%   76.68%   +0.03%     
============================================
  Files           162      162              
  Lines         80662    80645      -17     
============================================
+ Hits          61830    61846      +16     
+ Misses        18832    18799      -33     
Files with missing lines Coverage Δ
src/aof.c 80.30% <100.00%> (-0.07%) ⬇️
src/blocked.c 90.30% <100.00%> (ø)
src/db.c 94.95% <100.00%> (+0.14%) ⬆️
src/defrag.c 81.12% <100.00%> (ø)
src/dict.h 100.00% <100.00%> (ø)
src/eval.c 91.82% <100.00%> (ø)
src/functions.c 96.64% <100.00%> (ø)
src/latency.c 83.33% <100.00%> (ø)
src/module.h 0.00% <ø> (ø)
src/multi.c 97.90% <100.00%> (ø)
... and 17 more

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.