Skip to content

fix: duplicated words in networking/server/function_lua comments#3705

Open
vip892766gma wants to merge 1 commit into
valkey-io:unstablefrom
vip892766gma:fix/duplicated-words-in-server-and-modules-comments
Open

fix: duplicated words in networking/server/function_lua comments#3705
vip892766gma wants to merge 1 commit into
valkey-io:unstablefrom
vip892766gma:fix/duplicated-words-in-server-and-modules-comments

Conversation

@vip892766gma
Copy link
Copy Markdown

Three one-line typo fixes for duplicated words in source comments:

  • src/networking.c — "/* Returns the number of keys in the the incr_states array after adding keys. */" → "...in the incr_states array..."
  • src/modules/lua/function_lua.c — "* functions are also saved into the the registry of the Lua environment." → "... into the registry of the Lua environment."
  • src/server.c — "/* Dict for for case-insensitive search using null terminated C strings." → "/* Dict for case-insensitive search using null terminated C strings."

No code/behavior change.

Signed-off-by: Aiden Park 275402320+vip892766gma@users.noreply.github.com

Signed-off-by: Aiden Park <275402320+vip892766gma@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c8fce4f4-787b-4f52-8f85-e2ad2b2928c6

📥 Commits

Reviewing files that changed from the base of the PR and between fdf13ca and 885f6e5.

📒 Files selected for processing (3)
  • src/modules/lua/function_lua.c
  • src/networking.c
  • src/server.c

📝 Walkthrough

Walkthrough

Three comment lines across the codebase are corrected to remove duplicated words: the Lua function library comment, the networking module incr_states comment, and the server module stringSetDictType comment. No functional code is changed.

Changes

Comment typo corrections

Layer / File(s) Summary
Comment typo fixes
src/modules/lua/function_lua.c, src/networking.c, src/server.c
Three single-line comments are corrected to remove duplicated words: Lua registry description, incr_states array reference, and stringSetDictType case-insensitive description. No code logic changes.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: fixing duplicated words in comments across three files (networking, server, and function_lua modules).
Description check ✅ Passed The description is directly related to the changeset, providing specific before-and-after examples of the comment corrections made in all three files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants