Skip to content

Set repl-timeout for slotmigrations tests to prevent disconnections #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enjoy-binbin merged 1 commit into from
May 15, 2026
+4 −4
Merged

Set repl-timeout for slotmigrations tests to prevent disconnections #3703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/unit/cluster/cluster-migrateslots.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2445,7 +2445,7 @@ start_cluster 3 3 {tags {logreqres:skip external:skip cluster aofrw} overrides {
}
}

start_cluster 3 0 {tags {logreqres:skip external:skip cluster} overrides {cluster-require-full-coverage no slot-migration-max-failover-repl-bytes 0}} {
start_cluster 3 0 {tags {logreqres:skip external:skip cluster} overrides {cluster-require-full-coverage no slot-migration-max-failover-repl-bytes 0 repl-timeout 3600}} {
test "Slot migration remaining_repl_size on the source node" {
set 16383_slot_tag "{6ZJ}"
set_debug_prevent_pause 1
Expand All @@ -2465,7 +2465,7 @@ start_cluster 3 0 {tags {logreqres:skip external:skip cluster} overrides {cluste
pause_process [srv 0 pid]
set bigstr [string repeat x 1024000]
for {set j 0} {$j < 50} {incr j} {
R 2 set "$16383_slot_tag:key:" $bigstr
R 2 set "$16383_slot_tag:key" $bigstr
}

# Check R0 remaining repl size is OK.
Expand All @@ -2488,7 +2488,7 @@ start_cluster 3 0 {tags {logreqres:skip external:skip cluster} overrides {cluste
}
}

start_cluster 3 0 {tags {logreqres:skip external:skip cluster} overrides {cluster-require-full-coverage no slot-migration-max-failover-repl-bytes -1}} {
start_cluster 3 0 {tags {logreqres:skip external:skip cluster} overrides {cluster-require-full-coverage no slot-migration-max-failover-repl-bytes -1 repl-timeout 3600}} {
test "slot-migration-max-failover-repl-bytes -1 disables repl bytes limit" {
set 16383_slot_tag "{6ZJ}"

Expand All @@ -2506,7 +2506,7 @@ start_cluster 3 0 {tags {logreqres:skip external:skip cluster} overrides {cluste
pause_process [srv 0 pid]
set bigstr [string repeat x 1024000]
for {set j 0} {$j < 50} {incr j} {
R 2 set "$16383_slot_tag:key:$j" $bigstr
R 2 set "$16383_slot_tag:key" $bigstr
}

# Confirm the replication buffer has accumulated data.
Expand Down
Loading