cmake: Fix missing release_header dependency for cli, benchmark, and gtest#3683
cmake: Fix missing release_header dependency for cli, benchmark, and gtest#3683poiuj wants to merge 2 commits into
Conversation
…gtest release.c is compiled into valkey-cli, valkey-benchmark, and the valkeylib-gtest static library, but only valkey-server declared a dependency on the release_header custom target that runs mkreleasehdr.sh to generate src/release.h. On a clean build (no stale release.h on disk) or under high parallelism, those targets could attempt to compile release.c before the header was generated and fail with "release.h: No such file or directory". Add the missing add_dependencies(... release_header) for all three. Signed-off-by: Vadym Khoptynets <1099644+poiuj@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThree CMake build targets now explicitly depend on ChangesBuild dependency on release_header target
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
LGTM |
|
@zuiderkwast do you have time to look into this micro PR? |
zuiderkwast
left a comment
There was a problem hiding this comment.
I don't have the overview of the cmake files so I can't say if it's correct or not. But I trust @enjoy-binbin. 👍
release.c is compiled into valkey-cli, valkey-benchmark, and the valkeylib-gtest static library, but only valkey-server declared a dependency on the release_header custom target that runs mkreleasehdr.sh to generate src/release.h. On a clean build (no stale release.h on disk) or under high parallelism, those targets could attempt to compile release.c before the header was generated and fail with "release.h: No such file or directory".
Add the missing add_dependencies(... release_header) for all three.
Summary by CodeRabbit