Skip to content

fix(core): ensure tool_choice maps to structured object for AWS Bedrock compliance #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toshalkumbhar8979-design wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(core): ensure tool_choice maps to structured object for AWS Bedrock compliance #668

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9bea3f
fix(core): ensure tool_choice maps to structured object for AWS Bedro…
toshalkumbhar8979-design Jul 4, 2026
4634ae6
Update strix/core/execution.py
toshalkumbhar8979-design Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions strix/core/execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,15 @@ async def _run_cycle( # noqa: PLR0912, PLR0915
while True:
try:
await coordinator.mark_running(agent_id)

# --- PRODUCTION FIX FOR AWS BEDROCK TOOL_CHOICE COMPLIANCE ---
if hasattr(run_config, "extra_body") and isinstance(run_config.extra_body, dict):
if "tool_choice" in run_config.extra_body:
run_config.extra_body["tool_choice"] = {"type": "auto"}
elif hasattr(run_config, "tool_choice") and (run_config.tool_choice == "auto" or isinstance(run_config.tool_choice, str)):
run_config.tool_choice = {"type": "auto"}
Comment thread
toshalkumbhar8979-design marked this conversation as resolved.

@greptile-apps greptile-apps Bot Jul 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Explicit Tool Choice Becomes Auto

The isinstance(run_config.tool_choice, str) branch rewrites every string value to {"type": "auto"}. If a caller selects a specific tool by name, the request is changed to automatic selection before Runner.run_streamed, so the model can skip the required tool or call a different one.

Suggested change
elif hasattr(run_config, "tool_choice") and (run_config.tool_choice == "auto" or isinstance(run_config.tool_choice, str)):
run_config.tool_choice = {"type": "auto"}
elif hasattr(run_config, "tool_choice") and run_config.tool_choice == "auto":
run_config.tool_choice = {"type": "auto"}
Prompt To Fix With AI 
This is a comment left during a code review.
Path: strix/core/execution.py
Line: 357-358

Comment:
**Explicit Tool Choice Becomes Auto**

The `isinstance(run_config.tool_choice, str)` branch rewrites every string value to `{"type": "auto"}`. If a caller selects a specific tool by name, the request is changed to automatic selection before `Runner.run_streamed`, so the model can skip the required tool or call a different one.

```suggestion
            elif hasattr(run_config, "tool_choice") and run_config.tool_choice == "auto":
                run_config.tool_choice = {"type": "auto"}
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

# -------------------------------------------------------------

stream = Runner.run_streamed(
agent,
input=input_data,
Expand Down